Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename URLCredential to URLCredentialsProvider #81

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Jul 26, 2024

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.64%. Comparing base (b7a51a8) to head (2b216a1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   94.45%   97.64%   +3.18%     
==========================================
  Files          20       20              
  Lines        1281     1275       -6     
==========================================
+ Hits         1210     1245      +35     
+ Misses         56       16      -40     
+ Partials       15       14       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacksonTian JacksonTian requested a review from yndu13 July 28, 2024 02:12
@@ -12,7 +12,7 @@ import (
)

// URLCredential is a kind of credential
type URLCredential struct {
type URLCredentialsProvider struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是个非兼容更新,需要谨慎发布

@JacksonTian JacksonTian merged commit c6e412f into master Jul 29, 2024
8 checks passed
@JacksonTian JacksonTian deleted the rename branch July 29, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants