Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test cases for OIDC provider #85

Merged
merged 1 commit into from
Jul 29, 2024
Merged

improve test cases for OIDC provider #85

merged 1 commit into from
Jul 29, 2024

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Jul 29, 2024

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (10e1095) to head (e13d942).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   97.95%   99.06%   +1.10%     
==========================================
  Files          20       20              
  Lines        1274     1282       +8     
==========================================
+ Hits         1248     1270      +22     
+ Misses         14        6       -8     
+ Partials       12        6       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peze
Copy link

peze commented Jul 29, 2024

LGTM

@JacksonTian JacksonTian merged commit 9e570dd into master Jul 29, 2024
8 checks passed
@JacksonTian JacksonTian deleted the fixutre branch July 29, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants