Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine ecs ram role credentials provider #87

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Jul 29, 2024

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.84%. Comparing base (4705e5d) to head (ad4a8ba).

Files Patch % Lines
credentials/ecs_ram_role_credentials_provider.go 92.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   99.37%   99.84%   +0.46%     
==========================================
  Files          20       20              
  Lines        1282     1278       -4     
==========================================
+ Hits         1274     1276       +2     
+ Misses          4        0       -4     
+ Partials        4        2       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacksonTian JacksonTian force-pushed the refine_ecs_ram_role branch from b7c2310 to ad4a8ba Compare July 29, 2024 07:20
@peze peze closed this Jul 29, 2024
@peze peze reopened this Jul 29, 2024
@JacksonTian JacksonTian merged commit 8f9f1e2 into master Jul 29, 2024
15 checks passed
@JacksonTian JacksonTian deleted the refine_ecs_ram_role branch July 29, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants