Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ram role arn credentials provider #96

Merged
merged 1 commit into from
Aug 20, 2024
Merged

improve ram role arn credentials provider #96

merged 1 commit into from
Aug 20, 2024

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Aug 19, 2024

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.71186% with 22 lines in your changes missing coverage. Please review.

Project coverage is 93.15%. Comparing base (09e2c68) to head (a8ec063).

Files Patch % Lines
credentials/internal/providers/ram_role_arn.go 48.27% 14 Missing and 1 partial ⚠️
credentials/credential.go 76.66% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   94.60%   93.15%   -1.45%     
==========================================
  Files          26       26              
  Lines        1631     1651      +20     
==========================================
- Hits         1543     1538       -5     
- Misses         85      107      +22     
- Partials        3        6       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacksonTian
Copy link
Contributor Author

测试覆盖率下降主要因为代理部分。

@yndu13 yndu13 merged commit a4f7a0f into master Aug 20, 2024
8 checks passed
@yndu13 yndu13 deleted the ram2 branch August 20, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants