Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine the ecs ram role credentials provider #97

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Aug 20, 2024

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 98.55072% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.75%. Comparing base (09e2c68) to head (3da2b14).

Files Patch % Lines
credentials/credential.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   94.60%   96.75%   +2.15%     
==========================================
  Files          26       27       +1     
  Lines        1631     1759     +128     
==========================================
+ Hits         1543     1702     +159     
+ Misses         85       48      -37     
- Partials        3        9       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacksonTian JacksonTian merged commit 412f4ed into master Aug 20, 2024
8 checks passed
@JacksonTian JacksonTian deleted the ecs_ram_role branch August 20, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants