Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve all credentials providers #30

Merged
merged 1 commit into from
Oct 16, 2024
Merged

refactor: improve all credentials providers #30

merged 1 commit into from
Oct 16, 2024

Conversation

yndu13
Copy link
Contributor

@yndu13 yndu13 commented Aug 29, 2024

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 97.05594% with 30 lines in your changes missing coverage. Please review.

Project coverage is 97.49%. Comparing base (c61dca4) to head (c38bb47).

Files with missing lines Patch % Lines
src/Providers/CLIProfileCredentialsProvider.php 75.00% 22 Missing ⚠️
src/Providers/ProfileCredentialsProvider.php 97.67% 2 Missing ⚠️
src/Providers/RamRoleArnCredentialsProvider.php 98.27% 2 Missing ⚠️
src/Credential.php 99.11% 1 Missing ⚠️
src/Providers/DefaultCredentialsProvider.php 98.59% 1 Missing ⚠️
src/Providers/EcsRamRoleCredentialsProvider.php 98.78% 1 Missing ⚠️
...oviders/EnvironmentVariableCredentialsProvider.php 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #30      +/-   ##
============================================
- Coverage     98.80%   97.49%   -1.32%     
- Complexity      256      544     +288     
============================================
  Files            24       30       +6     
  Lines           672     1438     +766     
============================================
+ Hits            664     1402     +738     
- Misses            8       36      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yndu13 yndu13 force-pushed the providers branch 14 times, most recently from f3cb34e to 7343adc Compare October 14, 2024 16:16
@yndu13 yndu13 force-pushed the providers branch 12 times, most recently from 8db8a9b to 584d8c3 Compare October 16, 2024 04:52
@yndu13 yndu13 merged commit 4afbfc3 into master Oct 16, 2024
10 checks passed
@yndu13 yndu13 deleted the providers branch October 16, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants