fresh credentials #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsinghuaDream
force-pushed
the
master
branch
from
f6f2bc5 to
f0ac0da
Compare
yndu13
previously approved these changes
Jan 2, 2025
| @@ -55,12 +63,8 @@ protected function cache(array $credential) | |||
| */ | |||
| public function getCredentials() | |||
| { | |||
| $credentials = $this->getCredentialsInCache(); | |||
There was a problem hiding this comment.
$credentials = $this->getCredentialsInCache();
这里似乎不对。getCredentialsInCache这个不应该换掉，而是加一些逻辑。先判断是否到达了stale_time（过期时间提前15分钟），如果时间到了stale_time，就阻塞刷新，如果没到stale_time就判断是否到了prefetch_time（上次刷新后1小时），如果到了prefetch_time就异步刷新。只不过php不分同步还是异步，所以你全部写成同步。也就是每过1小时刷新一次，每次过期前15分钟刷新一次。既然每次1小时刷一次了，基本也就用不到提前15分钟的这个，15分钟就变成了用来做兜底
There was a problem hiding this comment.
也就是上面的self::$credentialsCache[$this->key()]缓存的内容，你得缓存每个凭证的prefetch时间和stale时间
There was a problem hiding this comment.
只不过到了prefetch时间的时候，去远程服务端拿新的凭证，是允许失败的，也就是catch住异常，不阻塞客户主业务，但是记录日志，让用户可以排查。但到了stale_time时，还是失败了，这时候给客户抛出异常
yndu13
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.