headers: make more headers self-contained #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some IDEs parse headers in isolation to populate their code model. This exposes some missing headers, mainly for alsa internal struct definitions, ssize_t (requiring sys/types.h), size_t (requiring string.h), va_args (requiring stdargs.h) or FILE (requiring stdio.h) This patch makes the main headers parsable by qtcreator
perexg
added a commit
that referenced
this pull request
Feb 2, 2025
Fixes several issues with header files: - prefer alsa/asoundlib.h file for the alsa-lib core functionalities (use #warning to inform current and future developers, do the job) - include alsa/asoundlib.h in headers for external plugins by default - pcm_external.h: dependencies cleanup - as benefit, the parsers in IDEs should get all information for individial header files (see PR#435) This change was mainly tergetted to fix errors caused by wrong include order (like for endianness detection, missing typedefs etc.). Closes: #431 Link: #435 Signed-off-by: Jaroslav Kysela <[email protected]>
|
Thanks for your PR. I did that a bit differently in ea8972c. Could you test with latest alsa-lib sources? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some IDEs parse headers in isolation to populate their code model. This exposes some missing headers, mainly for alsa internal struct definitions, ssize_t (requiring sys/types.h), size_t (requiring string.h), va_args (requiring stdargs.h) or FILE (requiring stdio.h)
This patch makes the main headers parsable by qtcreator