fix(#60): fix holiday matchers when date is not start of day #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 116 128 +12
Branches 23 29 +6
=========================================
+ Hits 116 128 +12
Continue to review full report at Codecov.
|
|
Thank you, will take a look this weekend |
amaidah
reviewed
Feb 17, 2022
| @@ -92,11 +101,14 @@ export const isLaborDay = function(inst) { | |||
| }); | |||
| const weekday = firstDayInSeptember.weekday; | |||
| const isFirstDayLaborDay = weekday === 1; | |||
| const memorialDay = isFirstDayLaborDay | |||
| const laborDay = isFirstDayLaborDay | |||
amaidah
reviewed
Feb 17, 2022
| const nyd2016 = DateTime.fromObject({ year: 2016, month: 1, day: 1 }); | ||
| const nyd1988 = DateTime.fromObject({ year: 1988, month: 1, day: 1 }); | ||
| const nyd2022 = DateTime.fromObject({ year: 2022, month: 1, day: 1 }); | ||
| const nyd2019 = DateTime.fromObject({ |
There was a problem hiding this comment.
Could we keep some tests that don't have hours explicitly defined?
There was a problem hiding this comment.
Actually, a better path forward now that I think about it more would be to create a series of tests for the various different ways to create a DateTime so thats .local() .fromObject .fromISO .now() etc.
amaidah
reviewed
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.