Add password file option to JMX config. #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okankoAMZ
reviewed
Feb 16, 2024
sethAmazon
reviewed
Feb 16, 2024
sethAmazon
reviewed
Feb 16, 2024
|
This will still add in plain text to the otel jar file? |
sethAmazon
previously approved these changes
Feb 16, 2024
okankoAMZ
previously approved these changes
Feb 16, 2024
okankoAMZ
previously approved these changes
Feb 16, 2024
sethAmazon
previously approved these changes
Feb 16, 2024
sky333999
previously approved these changes
Feb 16, 2024
jefchien
dismissed stale reviews from sky333999, sethAmazon, and okankoAMZ
via
3ed02e0
sky333999
approved these changes
Feb 16, 2024
okankoAMZ
approved these changes
Feb 16, 2024
KlwntSingh
pushed a commit
to KlwntSingh/opentelemetry-collector-contrib
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Instead of storing the password in plaintext in the receiver config, provide the option to read it in from a read-restricted file in a Java Properties file format.
Testing: Built and tested.
On start up if the file is missing:
When file is not read-restricted:
If both are valid, then on start up the password will be present in the
jmx-config-*.propertiesfile, which has 0600 access.A known issue is that if the file is also being used by the JMX agent and the file has read-write permissions, the JMX agent will hash the password, which the collector cannot use. The collector should use a separate file with only the passwords it needs.
Documentation: Added field to README for receiver.