Copy workflow for OCB components test and tagging from aws-ocb-dev branch
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
reviewed
Dec 6, 2024
| - name: Configure AWS Credentials | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| role-to-assume: arn:aws:iam::${{ env.ACCOUNT_ID }}:role/${{ secrets.E2E_TEST_ROLE_NAME }} |
There was a problem hiding this comment.
Why do this a 2nd time? Are we using one acct role to assume to another acct role? Curious what the overall setup here is.
There was a problem hiding this comment.
Are we using one acct role to assume to another acct role
Yes. We can workaround this by just adding the 2nd's account's role as another secret, but currently we re-use the existing secret of the 1st account to minimize the number of secrets we add to this repo. BTW the 1st account is currently being used to run the e2e test in the release workflow.
sky333999
approved these changes
Dec 6, 2024
mxiamxia
merged commit 66e9942
into
amazon-contributing:aws-cwa-dev
139 of 146 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Copy workflow for OCB components to the default branch from
aws-ocb-devbranch in order to executeworkflow dispatchin https://github.com/amazon-contributing/opentelemetry-collector-contrib/actionsaws-ocb-devbranchLink to tracking Issue:
Testing:
Documentation: