Don't try to close a connection that is in an error state #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a connection is in an error state (a restart of the RabbitMQ server for example), we shouldn't try to ask the server to close it, otherwise we potentially have to wait forever for the close-ok response.
slavik-pastushenko
approved these changes
Apr 19, 2024
|
have absolutely the same issue, can we merge it, please? cc @Keruspe |
|
The fix looks good but incomplete. Instead of checking whether we're in error state, we should check if we're connected. This way there won't be problems with connections that are closing either |
|
We probably need the same for Channel I guess? |
If a connection is not in the connected state (e.g. an error state due to a restart of the RabbitMQ server), we shouldn't try to ask the server to close it, otherwise we might have to wait forever for the close-ok response.
Done.
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client try to gracefully shutdown when it encounter an error it can, potentially, wait forever for a reply to the
connection::close()method. We see that a lot in our test environment where we kill services in arbitrary order to see if they can recover automatically.So this commit try to mitigate that.