Implement freezing and thawing of pins #78
+186
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclairevoyant
approved these changes
May 11, 2024
gilligan
reviewed
May 12, 2024
piegamesde
previously requested changes
May 13, 2024
|
Now that I actually think of it, what is the workflow of manually updating frozen pins? Unfreezing them just for that purpose seems a bit unwieldy. |
Perhaps an extra argument to the |
piegamesde
force-pushed
the
andir/freeze-pins
branch
from
de638f3 to
d62d910
Compare
This allows freezing a pin to ensure that it isn't changed by issuing a blanked `npins update`. Co-authored-by: piegames <[email protected]>
piegamesde
force-pushed
the
andir/freeze-pins
branch
from
d62d910 to
a20936d
Compare
Coca162
approved these changes
Feb 28, 2025
Comment on lines
721
to
729
| let (mut style, status) = if opts.names.is_empty() || valid_names.contains(name) { | ||
| (ContentStyle::new().grey(), "queued") | ||
| if pin.is_frozen() && !opts.update_frozen { | ||
| (ContentStyle::new().dark_grey(), "frozen") | ||
| } else { | ||
| (ContentStyle::new().grey(), "queued") | ||
| } | ||
| } else { | ||
| (ContentStyle::new().dark_grey(), "ignored") | ||
| }; |
There was a problem hiding this comment.
Would probably nicer turned into a match now:
let (mut style, status) = match (
opts.names.is_empty() || valid_names.contains(name),
pin.is_frozen() && !opts.update_frozen,
) {
(true, false) => (ContentStyle::new().grey(), "queued"),
(true, true) => (ContentStyle::new().dark_grey(), "frozen"),
(false, _) => (ContentStyle::new().dark_grey(), "ignored"),
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows freezing a pin to ensure that it isn't changed by issuing a blanked
npins update.Should fix #62