git: fix fetch on branch #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please state the issue this is solving and add a test case? |
thillux
force-pushed
the
fix-branch-fetch
branch
from
40146e1 to
51a4342
Compare
|
Test is currently WIP. I took me some time to reproduce my issue. After I started fixing the last checkout to the default branch in |
|
Do you have any idea, whats failing in the |
|
With the changes you've made, HEAD of the generated git repo points to a different rev than previously. You need to either restore the previous HEAD position, or update all test cases to point to a different commit. (Disclaimer: I only briefly looked at the diff and test log, I might be wrong) |
thillux
force-pushed
the
fix-branch-fetch
branch
from
51a4342 to
b5b17af
Compare
|
Please rebase again, I fixed a bug which was causing weird test failures |
Signed-off-by: Markus Theil <[email protected]>
The branch test was not working, until I fixed the default checked out branch in the repository. This was already marked by a comment as failing. Signed-off-by: Markus Theil <[email protected]>
thillux
force-pushed
the
fix-branch-fetch
branch
from
b5b17af to
eeb2752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npins was not able to use branches different from the default branch in my use case. A test is added, which tries to use test-branch, while the default upstream branch is main. I had to also fix the default branch for other tests while doing this.