fig segfault in xlsx file #905
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-bonecutter
force-pushed
the
main
branch
from
f1bb63f to
d268bcf
Compare
|
Hello. Do you have the xlsx file that made sc-im to segfault? Where did you generate it? thanks. |
I cannot share this one as it’s for work but I can try to create a minimal reproduction when I get some spare time |
|
@jordan-bonecutter ok thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not super familiar with the codebase, but there is a segfault on line 351. It seems there is some interpreter which reads the string output of this line and I would assume it's more correct to set this value to NULL or some empty value as opposed to 0 but I am unfamiliar with the interpreter. Open to suggestions on the proper way to do this.