Implement Nounable Protocol for Booleans #1817
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariari
reviewed
Jan 24, 2025
apps/anoma_lib/lib/noun/nounable.ex
Outdated
Comment on lines
62
to
68
| @spec from_noun(Noun.t()) :: {:ok, list(Noun.t())} | :error | ||
| def from_noun(0), do: {:ok, true} | ||
| def from_noun(1), do: {:ok, false} | ||
|
|
||
| def from_noun(_) do | ||
| :error | ||
| end |
There was a problem hiding this comment.
No, it is not
Nounable for Atom only implements to_noun
Even then, it would have different semantics
agureev
force-pushed
the
artem/noun-nounable-bool
branch
from
a69f21a to
0e086ae
Compare
agureev
commented
Jan 24, 2025
Comment on lines
+52
to
+56
| def to_noun(bool) when bool in [true, false] do | ||
| Nounable.to_noun(bool) | ||
| end | ||
|
|
||
| def to_noun(), do: :error |
There was a problem hiding this comment.
This is specifically for converting to noun something that we assume is a boolean so that if it is another atom it fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.