Avoid duplicated signatures when building transactions #4230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4203.
This PR modifies adds a new method on the
Tx
type to remove duplicated sections. This function is then called in the signing function before producing the wrapper signature (which is computed on all the sections) and thedump_tx
function (in case the dumped tx needed to be signed offline).To support this logic the
PartialEq
implementation for theAuthorization
type is now manually provided and ignores the way the signer is specified, focusing instead on the targets and the actual signature.As a side note, also the
PartialEq
implementation forSigningTxData
has been updated to account for the shielded hash.Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo