Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid running cometbft as a validator when tendermint_node is set to non-validator #4245

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jan 17, 2025

Describe your changes

closes #4139

The PR adds a new field in config last_tendermint_mode (non-breaking as it's optional) which will be persisted on node start-up. If the mode changes from validator to non-validator, the node will backup and replace the validator key and state in the CometBFT dir.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic requested a review from grarco January 17, 2025 14:24
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 2.94118% with 66 lines in your changes missing coverage. Please review.

Project coverage is 74.55%. Comparing base (9eb747c) to head (c802a29).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/lib.rs 0.00% 43 Missing ⚠️
crates/apps_lib/src/tendermint_node.rs 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4245      +/-   ##
==========================================
- Coverage   74.59%   74.55%   -0.04%     
==========================================
  Files         342      342              
  Lines      108771   108832      +61     
==========================================
+ Hits        81135    81138       +3     
- Misses      27636    27694      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 20, 2025
mergify bot added a commit that referenced this pull request Jan 20, 2025
@mergify mergify bot merged commit 9c8bb71 into main Jan 20, 2025
23 of 25 checks passed
@mergify mergify bot deleted the tomas/fix-tm-mode branch January 20, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configuration tendermint_mode=Full has unexpected behavior may lead to double sign
2 participants