Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makie plotting #12

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Makie plotting #12

merged 2 commits into from
Feb 17, 2025

Conversation

anowacki
Copy link
Owner

  • Implement plotting with Makie via package extension
  • Update README to reflect Makie plotting

If the user has loaded a Makie backend (e.g., via `using GLMakie`),
the following new functions are available:

- `plot_array_response[!]`
- `plot_beamforming[!]`
- `plot_vespagram[!]`

Each of these will create a plot in the version without a `!` or plot
into a new grid position, or into an existing `Makie.Axis` for the
mutating version.
Replace VSG images from Plots with PNGs from Makie, and add
information to the README about using Makie-based plotting.
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 1.59574% with 185 lines in your changes missing coverage. Please review.

Project coverage is 45.16%. Comparing base (d041080) to head (9d2dd20).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
ext/plot_vespagram.jl 0.00% 61 Missing ⚠️
ext/plot_beamforming.jl 0.00% 54 Missing ⚠️
ext/generic.jl 0.00% 39 Missing ⚠️
ext/plot_arf.jl 0.00% 31 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #12       +/-   ##
===========================================
- Coverage   58.86%   45.16%   -13.70%     
===========================================
  Files          10       14        +4     
  Lines         598      786      +188     
===========================================
+ Hits          352      355        +3     
- Misses        246      431      +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anowacki anowacki merged commit 95a26a7 into master Feb 17, 2025
7 of 9 checks passed
@anowacki anowacki deleted the makie-plots branch February 17, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant