Unpin jinja2 requirements
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NilashishC
requested review from
ssbarnea and
shatakshiiii
and removed request for
a team
NilashishC
added
the
skip-changelog
ssbarnea
changed the title
jinja2 requirement to >=3.1.3jinja2 requirements
ssbarnea
added
bug
NilashishC
commented
Feb 1, 2024
NilashishC
commented
Feb 1, 2024
Signed-off-by: NilashishC <[email protected]>
Signed-off-by: NilashishC <[email protected]>
Signed-off-by: NilashishC <[email protected]>
| @@ -48,6 +50,7 @@ commands = | |||
|
|
|||
| [testenv:lint] | |||
| description = Enforce quality standards under {basepython} ({envpython}) | |||
| base_python = python3.9 | |||
There was a problem hiding this comment.
Suggested change
| base_python = python3.9 | |
| base_python = python3.10 |
since 3.9 support has been removed
| optional-dependencies.docs = {file = [".config/docs-requirements.txt"]} | ||
| optional-dependencies.test = {file = [".config/requirements-test.txt"]} | ||
| dependencies = {file = ".config/requirements.in"} | ||
| optional-dependencies.docs = {file = [".config/docs-requirements.in"]} |
There was a problem hiding this comment.
@NilashishC just to keep the same pattern as other projects, could you please rename to requirements-docs.in and requirements-test.in
| entry: pip-compile -q --no-annotate --output-file=.config/constraints.txt pyproject.toml --all-extras --strip-extras | ||
| files: ^.config\/.*(requirements|constraints).*$ | ||
| language: python | ||
| language_version: "3.9" # minimal we support officially |
There was a problem hiding this comment.
Suggested change
| language_version: "3.9" # minimal we support officially | |
| language_version: "3.10" # minimal we support officially |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.