Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with ansible-core 2.18 #1882

Merged
merged 21 commits into from
Jan 20, 2025
Merged

Compatibility with ansible-core 2.18 #1882

merged 21 commits into from
Jan 20, 2025

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Nov 22, 2024 •
edited
Loading

  • Bump core to 2.18
  • Ignore new GALAXY_SERVERS entries in ansible-config dump and list
  • Default to pytest's interpreter when running tests from vscode test tree
  • Update test images to dev-tools and fedora 40
  • Update all fixtures as needed

Note: The ansible-dev-tools image still has core 2.17.6, so this will need to be done again in the future once it has 2.18.0

@cidrblock cidrblock requested a review from a team as a code owner November 22, 2024 18:22
@github-actions github-actions bot added the bug Researched, reproducible, committed to fix label Nov 22, 2024
@cidrblock cidrblock changed the title ansible-core 2.18 updates Compatibility with ansible-core 2.18 Nov 22, 2024
@shatakshiiii shatakshiiii marked this pull request as draft December 4, 2024 13:05
@shatakshiiii shatakshiiii marked this pull request as ready for review January 17, 2025 09:15
shatakshiiii
shatakshiiii previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@shatakshiiii shatakshiiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@abhikdps abhikdps requested a review from shatakshiiii January 17, 2025 09:37
@shatakshiiii shatakshiiii added enhancement New feature or request and removed bug Researched, reproducible, committed to fix labels Jan 20, 2025
@shatakshiiii shatakshiiii marked this pull request as draft January 20, 2025 09:35
@shatakshiiii shatakshiiii marked this pull request as ready for review January 20, 2025 10:04
abhikdps
abhikdps approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@abhikdps abhikdps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@shatakshiiii shatakshiiii merged commit 12272bf into ansible:main Jan 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhikdps abhikdps abhikdps approved these changes

@shatakshiiii shatakshiiii shatakshiiii approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
🧰 devtools project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cidrblock @shatakshiiii @abhikdps