Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebRTC, HLS and DASH buttons to Web Panel #184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SelimEmre
Copy link
Contributor

@SelimEmre SelimEmre requested a review from mekya August 28, 2022 19:13
@asharamseervi
Copy link
Collaborator

This is nice to have @SelimEmre, what's say?

@SelimEmre
Copy link
Contributor Author

SelimEmre commented Nov 30, 2022

This is nice to have @SelimEmre, what's say?

I think it's Ok, I will ping my colleagues to merge this PR. It looks like as below:

Screenshot 2022-11-30 at 23 36 02

@asharamseervi
Copy link
Collaborator

This is nice to have @SelimEmre, what's say?

I think it's Ok, I will ping my colleagues to merge this PR. It looks like as below:

Screenshot 2022-11-30 at 23 36 02

This seems great add-on; users will have clarity what type of stream they're initiating. Is this possible to be dynamic if User had already disabled DASH Streaming; or somehow Dash isn't available to stream/play; Play Dash button shouldn't be visible
or
just disabled button will be good to have?

PS: If this PR is ready, we may merge it now and can add this type of feature extension in future releases as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants