Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: g版本升级,supportsCSSTransform=true是默认设置 #6567

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

interstellarmt
Copy link
Contributor

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

解决类型错误:Property 'supportsCSSTransform' does not exist on type 'CanvasConfig'
底层依赖g版本升级,supportsCSSTransform=true是默认设置,g2中不再需要设置supportsCSSTransform属性

Copy link

Walkthrough

此PR解决了类型错误,移除了对supportsCSSTransform属性的显式设置,因为在底层依赖的g版本升级后,该属性默认设置为true

Changes

文件 概要
tests/unit/api/chart.spec.ts 移除了不再需要的测试用例,该用例检查canvas.supportsCSSTransform是否设置为true
src/api/runtime.ts 移除了对supportsCSSTransform属性的显式设置,因为它现在是默认值。

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12511288540

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 86.697%

Totals Coverage Status
Change from base Build 12365784121: -0.007%
Covered Lines: 10613
Relevant Lines: 11865

💛 - Coveralls

@hustcc hustcc merged commit 21efda5 into v5 Dec 27, 2024
2 checks passed
@hustcc hustcc deleted the fix-1227 branch December 27, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants