-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply changes from reverted PR 3423: move structures to new modules #4427
Conversation
ad01f1c
to
c7ffd36
Compare
c7ffd36
to
780be19
Compare
6d16879
to
b0948e1
Compare
@@ -1,5 +1,11 @@ | |||
#[deprecated( | |||
since = "2.1.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the version here in case of backporting
are the changes that are intended to be backported all already in? ideally we do not take a bunch of refactor/reorg/cosmetics through backport. just logic changes |
No, in order for the validator to be able to use tpu-client-next, I need to add the following:
So although these changes do not change much of the logic, they are big code-wise. Moving data structures to the new place might be postponed and done after (3), bu they are quite risk-free changes. |
I think it is reasonable now to retreat on backporting to 2.1 (because there are a lot of changes), so move these structures around |
7101ea0
to
8c4eda7
Compare
8c4eda7
to
f1fb95b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nothing after this is intended for backport, right? we aren't backporting reorg/refactor changes |
correct, no backporting |
Problem
This PR moves structures
SendTransactionServiceStats
andTransactionClient
(introduced recently) to their own modules: these changes are split into two commits for simplicity of the review. There are no changes in the logic, just moves code to new modules.Summary of Changes