Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply 3515: Add new_with_client constructor to SendTransactionService #4754

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

KirillLykov
Copy link

@KirillLykov KirillLykov commented Feb 3, 2025

Summary of Changes

This PR doesn't have any logic changes, instead it prepares ground for future modifications by:

  • Introduce new_with_client constructor for SendTransactionService
  • Introduce some test utilities functions to help with using this method for different implementations of Client trait

This PR adds back part of changes from #3515

@KirillLykov KirillLykov force-pushed the klykov/add-trait-template-sts branch from 1f55288 to ad030d3 Compare February 3, 2025 17:21
@KirillLykov KirillLykov added the automerge automerge Merge this Pull Request automatically once CI passes label Feb 3, 2025
@mergify mergify bot merged commit da53f42 into anza-xyz:master Feb 5, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants