Reapply 3515: add tpu client next to sts #4758
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
KirillLykov
force-pushed
the
klykov/add-tpu-client-next-to-sts-again
branch
from
3be592a to
96192fd
Compare
KirillLykov
force-pushed
the
klykov/add-tpu-client-next-to-sts-again
branch
from
96192fd to
f20cc08
Compare
|
CI breaks for unrelated reasons, fixed CI problem in this PR: #4809 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Introduce
TpuClientNextClientto theSendTransactionService(STS). So user of can choose which client to use:ConnectionCacheClientorTpuClientNextClient. By default it isConnectionCacheClientand, hence, it is used in the RPC service. Which means that no changes on the validator behavior.Both clients implement now
NotifyKeyUpdate. This is need for the client to use a new validator identity when a corresponding admin rpc call is sent. Not used as part of these changes, because currently in the validator.rs we useConnectionCachedirectly and this notify handling is done there.This PR partially adds back reverted PR #3515.
Summary of Changes