Fix disabled thoguhts in few shots in ReAct prompt

aorwall · Jan 27, 2025 · 6a85465 · 6a85465
1 parent 6114c9c
commit 6a85465
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/moatless/agent/agent.py b/moatless/agent/agent.py
@@ -25,7 +25,7 @@
 class ActionAgent(BaseModel):
     system_prompt: str = Field(..., description="System prompt to be used for generating completions")
     use_few_shots: bool = Field(False, description="Whether to use few-shot examples for generating completions")
-    thoughts_in_action: bool = Field(True, description="")
+    disable_thoughts: bool = Field(False, description="Whether to disable thoughts in the action")
     actions: List[Action] = Field(default_factory=list)
     message_generator: MessageHistoryGenerator = Field(
         description="Generator for message history",
@@ -217,8 +217,8 @@ def generate_few_shots(self) -> str:
                         "InsertLinesArgs",
                         "FindCodeSnippetArgs",
                     ]:
-                        prompt += f"\nTask: {example.user_input}"
-                        if self.thoughts_in_action:
+                        prompt += f"\nTask: {example.user_input}\n"
+                        if not self.disable_thoughts:
                             prompt += f"\nThought: {thoughts}\n"
                         prompt += f"Action: {str(example.action.name)}\n"
 
@@ -260,13 +260,13 @@ def generate_few_shots(self) -> str:
 
                 elif self.completion.response_format == LLMResponseFormat.TOOLS:
                     tools_json = {"tool": example.action.name}
-                    if self.thoughts_in_action:
-                        tools_json.update(example.action.model_dump())
-                    else:
+                    if self.disable_thoughts:
                         tools_json.update(example.action.model_dump(exclude={"thoughts"}))
+                    else:
+                        tools_json.update(example.action.model_dump())
 
                     prompt += f"Task: {example.user_input}\n"
-                    if not self.thoughts_in_action:
+                    if not self.disable_thoughts:
                         prompt += f"<thoughts>{example.action.thoughts}</thoughts>\n"
                     prompt += json.dumps(tools_json)
                     prompt += "\n\n"

diff --git a/moatless/agent/code_agent.py b/moatless/agent/code_agent.py
@@ -140,7 +140,7 @@ def create(
                 system_prompt += REACT_CORE_OPERATION_RULES
 
         elif completion_model.response_format == LLMResponseFormat.TOOLS:
-            system_prompt += generate_react_guidelines(thoughts_in_action)
+            system_prompt += generate_react_guidelines(disable_thoughts)
         else:
             raise ValueError(f"Unsupported response format: {completion_model.response_format}")
 

diff --git a/moatless/agent/code_prompts.py b/moatless/agent/code_prompts.py
@@ -3,8 +3,8 @@
 """
 
 
-def generate_react_guidelines(thoughts_in_action: bool = True) -> str:
-    if not thoughts_in_action:
+def generate_react_guidelines(disable_thoughts: bool = False) -> str:
+    if not disable_thoughts:
         return """# Action and ReAct Guidelines
 
 1. **Analysis First**