Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow zones to be edited #186
Allow zones to be edited #186
Changes from 29 commits
08c3d23
3cc13cc
d116ec6
53e0110
3411e68
514c841
c707848
22cf30b
fa67b8b
f3da218
ba89e78
efc7a0c
c4af0c8
eab5534
382302e
6a01c0c
5753762
75b1ca7
01059c5
543f26a
e3a894e
dfd98fd
e2c919e
7f342a0
a53c08c
d5bd3d2
6053c73
4107f24
895b614
9002b1e
b10516f
f7ddc1a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that previously, the Screen was always first in the list. I think if it's no big deal to add, it might be nice to keep that 'feature'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm weird... I didn't think I changed anything that would affect ordering here. I also haven't seen
Screen
anywhere but the top. I'll investigateThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think the only way this could happen is if
api.get_zones
returnsScreen
not as the first Zone. Do you know why that would happen?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it, and it appears that api.get_zones() returns Screen first, but api.get_zones(stream_id=...) returns Screen last (or maybe everything just in inverse order?).
I only have two streams of sample size, but hey.
Since this is more of a UI thing, we probably don't want to rely on the server to maintain this visual nicety. We could add this after the api.get_zones() call, to ensure the Screen zone is always first:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyways, I approved the PR, but this would be a visual nicety to have. It makes sense to have the "always persistent" uneditable zone at the top of the list always.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this functionality changed during this PR? I'm inclined to open an issue and change this in a different changeset. Also, the backend should probably be changed to have consistent ordering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, yeah, it changed in the sense that now Screen is always at the bottom as opposed to always being at the top.
I consider it a minor UI regression, because I think most brainframe users have gotten used to the screen being right at the top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be resolved now