Re-enable editing existing zones #187
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velovix
approved these changes
Aug 19, 2021
BryceBeagle
force-pushed
the
feature/181-edit-existing-regions
branch
2 times, most recently
from
cfb210c to
d55bd80
Compare
BryceBeagle
force-pushed
the
feature/181-edit-existing-regions
branch
from
d55bd80 to
16c69ab
Compare
|
Is this good to go? |
|
@velovix I think this PR was intended to be merged into another branch, where Bryce would flesh out the zone editing to allow moving nodes around. I'm not sure this was intended to be merged into I could be wrong tho |
|
Yeah this branch was only supposed to be a draft at most, whoops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #186, we made it so that when zones are edited, the are restarted w/o any points as a temporary stop-gap until zone points can be rearranged, or at least removed. Later PRs will add both of those features and build upon this PR