Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Try Number to Attempt #45489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jan 8, 2025

Try Number is fine as the column entry. But I think "Attempt" is a more intuitive name for users.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 8, 2025
@eladkal
Copy link
Contributor

eladkal commented Jan 8, 2025

Try Number is fine as the column entry. But I think "Attempt" is a more intuitive name for users.

Try number is very well received term. I suggest to consider the implications...
I find it easier when the UI speaks the same language than code. try number is something that all airflow users are aware of and familiar with - changing the terminology just in the ui might cause confusion.

I don't feel strongly about this so if others are fine with it lets merge.

@jscheffl
Copy link
Contributor

jscheffl commented Jan 8, 2025

I'd also rather recommend to keep it the same name - and stronger opinion is to have it consistent. If we change the name in UI then we should also change the name in DB and API/Code consistenly, else this is very confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants