-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Pools under the admin nav button #45587
Conversation
I have currently utilised the Run status colour which closely aligns with the pool slot options. Reason to that is, run status colours are used all over the UI from a single source of truth(airflow/ui/src/utils/stateColor.ts). Just to not confuse users I kept the same colours of that. The stateColor currently used are:
One advantage of this would be when users will personalise the status colours of runs (https://airflow.apache.org/docs/apache-airflow/1.10.13/howto/customize-state-colors-ui.html) these values will also change. If we should have a fixed colour, we can use the below options: (Open to discussion)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left a few comments.
I would also like to play with adding an icon to each pool slot so it can be more accessible vs just via color. Doesn't have to be this PR, I just wanted to put the idea out there.
@bbovenzi Also, regarding slots icons, let me think of something, will try something COOL in upcoming PRs! |
3d704c1
to
9a43060
Compare
Pools option:
Deferred flag status:
Different slots:
related: #43706
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.