Skip to content

Commit

Permalink
Make use staged sdk harness effective whenever experiment flag added (#…
Browse files Browse the repository at this point in the history
…33954)

* Make use staged sdk harness effective whenever experiment flag added

* swap branch
  • Loading branch information
Abacn authored Feb 13, 2025
1 parent e651aed commit dcf4839
Showing 1 changed file with 9 additions and 14 deletions.
23 changes: 9 additions & 14 deletions sdks/java/container/boot.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,24 +153,19 @@ func main() {
cp = append(cp, filepath.Join(jarsDir, jar))
}
}
cp = append(cp, filepath.Join(jarsDir, javaHarnessJar))

var hasWorkerExperiment = strings.Contains(options, "use_staged_dataflow_worker_jar")

if hasWorkerExperiment {
// Skip adding system "beam-sdks-java-harness.jar". User-provided jar will
// be added to classpath as a normal user jar further below.
logger.Printf(ctx, "Opted to use staged java harness. Make sure beam-sdks-java-harness is included or shaded in the staged jars.")
} else {
cp = append(cp, filepath.Join(jarsDir, javaHarnessJar))
}

for _, a := range artifacts {
name, _ := artifact.MustExtractFilePayload(a)
if hasWorkerExperiment {
if strings.HasPrefix(name, "beam-sdks-java-harness") {
// Remove system "beam-sdks-java-harness.jar". User-provided jar will be
// added to classpath as a normal user jar further below.
for i, cl := range cp {
if !strings.HasSuffix(cl, javaHarnessJar) {
continue
}
logger.Printf(ctx, "Using staged java harness: %v", name)
cp = append(cp[:i], cp[i+1:]...)
break
}
}
if name == "dataflow-worker.jar" {
continue
}
Expand Down

0 comments on commit dcf4839

Please sign in to comment.