Skip to content

Commit

Permalink
[7X] Removed redundant tests
Browse files Browse the repository at this point in the history
Following gprecoverseg scenarios are not valid-

* SIGINT on gprecoverseg should delete the progress file
* SIGINT on gprecoverseg differential recovery should delete the progress file

Reason: if user selects yes when prompted for input at the time of interrupt,
gprecoverseg will be terminated and segments will still be down. If user selects
no, then recovery will continue marking the segments up but progress file will
exist. Hence above scenarios are invalid.

Assertion of progress file deletion has been covered already in following scenario:
* gprecoverseg should terminate on SIGINT when user selects Yes in the prompt
  • Loading branch information
Annu149 authored and yjhjstz committed Jan 27, 2025
1 parent 21e41c2 commit ed35e21
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions gpMgmt/test/behave/mgmt_utils/gprecoverseg.feature
Original file line number Diff line number Diff line change
Expand Up @@ -629,29 +629,6 @@ Feature: gprecoverseg tests
And user can start transactions
And all files in gpAdminLogs directory are deleted on all hosts in the cluster

@demo_cluster
@concourse_cluster
Scenario: SIGINT on gprecoverseg should delete the progress file
Given the database is running
And all the segments are running
And the segments are synchronized
And all files in gpAdminLogs directory are deleted on all hosts in the cluster
And user immediately stops all primary processes for content 0,1,2
And user can start transactions
And sql "DROP TABLE IF EXISTS test_recoverseg; CREATE TABLE test_recoverseg AS SELECT generate_series(1,100000000) AS a;" is executed in "postgres" db
And the user suspend the walsender on the primary on content 0
When the user asynchronously runs "gprecoverseg -aF" and the process is saved
Then the user waits until recovery_progress.file is created in gpAdminLogs and verifies its format
Then verify if the gprecoverseg.lock directory is present in coordinator_data_directory
When the user asynchronously sets up to end gprecoverseg process with SIGINT
And the user waits until saved async process is completed
Then recovery_progress.file should not exist in gpAdminLogs
Then the user reset the walsender on the primary on content 0
Then the gprecoverseg lock directory is removed
And the user waits until mirror on content 0,1,2 is up
And verify that lines from recovery_progress.file are present in segment progress files in gpAdminLogs
And the cluster is rebalanced

@demo_cluster
@concourse_cluster
Scenario: SIGHUP on gprecoverseg should not display progress in gpstate -e
Expand Down

0 comments on commit ed35e21

Please sign in to comment.