feat(bar): provide more options for emphasis focus ('stack', … #20724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries', and 'dataIndex'). close apache#20723
echarts-bot
bot
added
PR: awaiting doc
|
Thanks for your contribution! Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
Ovilia
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Please add test cases for the PR based on https://github.com/apache/echarts/wiki/How-to-make-a-pull-request#test
| @@ -450,6 +452,7 @@ export function blurSeries( | |||
| } | |||
|
|
|||
| const targetSeriesModel = ecModel.getSeriesByIndex(targetSeriesIndex); | |||
| const targetStack = targetSeriesModel.option.type === 'bar' && (targetSeriesModel.option as BarSeriesOption).stack; | |||
There was a problem hiding this comment.
Please use targetSeriesModel.get('type') instead of accessing option directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…'stackSeries', and 'dataIndex'). close #20723
Brief Information
This pull request is in the type of:
What does this PR do?
Implement new options for
emphasis.focus: 'stack' | 'stackSeries' | 'dataIndex'Fixed issues
Details
Before: What was the problem?
On stacked bar charts, on hover, need to be able to emphasize the stack (not just 'self'):
After: How does it behave after the fixing?
You can specify
emphasis: { focus: 'stack' }in the options.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
Others
Merging options
Other information
What tests I should add?