-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33265] Support source parallelism setting for Kafka connector #134
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
120c84e
to
6ffb8cc
Compare
@BIOINSu @libenchao Could you help take a review when you have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @X-czh for the contribution.
Looks good to me on the whole.
I left a few of comments.
Please let me know what's your opinon~
...n/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaDynamicTableFactory.java
Show resolved
Hide resolved
...est/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
@RocMarshal Thanks for the comments, I've addressed them in a new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update~
LGTM +1.
What is the purpose of the change
Support source parallelism setting for Kafka & Upsert-Kafka connector.
Brief change log
scan.parallelism
support for Kafka & Upsert-Kafka connector.Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no) yesDocumentation