-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-36821] Update to Kafka 3.9.0 #138
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Thomas Cooper <[email protected]>
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
@@ -156,6 +157,11 @@ public List<PartitionInfo> partitionsFor(String topic) { | |||
return kafkaProducer.metrics(); | |||
} | |||
|
|||
@Override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems unrelated to the version change. If it is related please could you add a unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the Producer
interface has changed between 3.4 and 3.9, this new method is required in order for the class to compile (I should have mentioned that in the PR description).
As this class is deprecated anyway and calls the wrapped KafkaProducer's client instance ID method (which is tested), is a unit test strictly required?
Whether the 3.9.0 version Kafka client is compability with the low version Kafka and zookeeper image? |
Yes, Kafka client 3.9.0 supports old version of Kafka and zookeeper image. |
Currently, the Flink Kafka Connector uses Kafka client version 3.4.0.
This has a medium severity vulnerability (CVE-2024-31141) and needs to be upgraded to >= 3.8.0 to address it.
3.9.0 is the most recently released version and between that and 3.4.0 there have been numerous bug and performance fixes.
This PR:
FlinkKafkaInternalProducer
now that theProducer
interface has changed between the 3.4 and 3.9 Kafka client versions.I am not familiar with ArchUnit, but it appears the violation file changes have been checked into previous commits so I have included them here aswell.