-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-36648] Bump Flink version to Flink 2.0-preview1 #140
base: main
Are you sure you want to change the base?
Conversation
@PatrickRen Would you like to review this PR when you have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lvyanquan Thanks for the awesome contribution! I found more classes that can be removed.
I simply searched keyword deprecated
in the repo, and there are still some appearances. Could you check them all?
Also I see a lot of empty files under flink-connector-kafka/archunit-violations
. I think we should remove them as well.
...ector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaContextAware.java
Outdated
Show resolved
Hide resolved
...ka/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaDeserializationSchema.java
Outdated
Show resolved
Hide resolved
...afka/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaSerializationSchema.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicPartitionTest.java
Outdated
Show resolved
Hide resolved
...a/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java
Show resolved
Hide resolved
Remove some empty files, and remain some files which were referenced in stored.rules. |
E2e case would fail, as there is a bug in Collect Sink in 2.0-preview version. Should I delete or comment these cases out? WDYT @PatrickRen. |
Bump Flink version to Flink 2.0-preview1.
This is required as flink-example module and flink-e2e-to-e2e-tests need to use Kafka connector for testing, and some other project like Apache Paimon also rely on Kafka connector in test.
This pr is based on #139 to remove many deprecated classes.
And as there is a bug in SinkTestSuiteBase/SourceTestSuiteBase in Flink 2.0-preview1 as https://issues.apache.org/jira/browse/FLINK-36845 described, temporarily commented relevant test as this will need to wait for a new release of Flink(Or we can directly cover these classes).