Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subnet setting for Proxy user #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsjsdbd
Copy link

@tsjsdbd tsjsdbd commented Dec 26, 2019

By default, Docker use 172.17.0.0/16 to docker0 interface. like:

docker0   Link encap:Ethernet  HWaddr 02:42:91:7b:0f:21  
          inet addr:172.17.0.1  Bcast:172.17.255.255  Mask:255.255.0.0

and by default, Docker-compose will use 172.18.0.0/16, 172.19.0.0/16 ...and so on, to new Bridge, like:

br-c401dc9ce9fd Link encap:Ethernet  HWaddr 02:42:ac:c9:28:9e  
          inet addr:172.18.0.1  Bcast:172.18.255.255  Mask:255.255.0.0

But, My environment have proxy endpoint: 172.18.22.221, if can not setting subnet of docker-compose, the default subnet adderess will conflict with my Proxy, which cause it can not work.

so, add subnet setting is meaningful for Proxy user : )

@tsjsdbd
Copy link
Author

tsjsdbd commented Dec 27, 2019

@fhueske
It's no effect on the Non-Proxy user, just more friendly for proxy user。

@tsjsdbd
Copy link
Author

tsjsdbd commented Jan 6, 2020

@fhueske @alpinegizmo @knaufk @rmetzger
any suggesting? I can improve the PR like changing the default CIDR value if you need.

@fhueske
Copy link
Contributor

fhueske commented Jan 7, 2020

Thanks for the PR @tsjsdbd and sorry for the delay.
The change looks good (based on my somewhat rusty networking knowledge).
I'll try it out and have a closer look tomorrow.
Best, Fabian

@patricklucas
Copy link

@tsjsdbd I think this issue doesn't affect that many people, and picking another arbitrary IP range (like 10.103/16) could possibly break things for other people who happen to already use it.

Have you tried setting the default-address-pools setting on your Docker daemon? (see this comment) I just tried it on my machine (Docker Desktop 2.1.0.5 on Mac) and it worked fine.

@tsjsdbd
Copy link
Author

tsjsdbd commented Jan 14, 2020

@patricklucas I realize that default CIDR using 10.103/16 may not very generic, but still want to leave a chance to those people who may facing this problem. So I will improve the PR by changing the default CIDR value to 172.18/16 .
And for Docker daemon conf, as it is allready used before using this playground(maybe some container is running), so it's better not change Docker,but have chance to change the new comming component, right?。
hope i can involve in flink community , Flink is really good.

By default, Docker use `172.17.0.0/16` to `docker0` interface.  like:
```
docker0   Link encap:Ethernet  HWaddr 02:42:91:7b:0f:21
          inet addr:172.17.0.1  Bcast:172.17.255.255  Mask:255.255.0.0
```
and by default, Docker-compose will use `172.18.0.0/16`, `172.19.0.0/16` ...and so on, to new Bridge, like:
```
br-c401dc9ce9fd Link encap:Ethernet  HWaddr 02:42:ac:c9:28:9e
          inet addr:172.18.0.1  Bcast:172.18.255.255  Mask:255.255.0.0
```
But, My environment have proxy endpoint: `172.18.22.221`,  if can not setting subnet of docker-compose, the default subnet adderess will conflict with my Proxy, which cause it can not work.

so, add subnet setting is meaningful for Proxy user : )
@xueIove
Copy link

xueIove commented Jun 24, 2021

Can you share the metadata?

vidma added a commit to vidma/flink-playgrounds that referenced this pull request May 16, 2022
* M1  fix again
* export STATS_COMPUTE_INTERVAL_MINUTES env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants