Fix sep directive in syntax A breaks templates in syntax B #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have an ICLA signed at Apache? Otherwise I can't merge code changes that are not entirely trivial. If not, I can just redo this without looking, now that the issue is known (Thanks!). Or you may prefer to sign the ICLA. |
|
I don't have an ICLA, but I'm happy to sign it. Any specific instructions or shall I just follow https://www.apache.org/licenses/contributor-agreements.html#submitting ? Thanks! |
|
Just follow that, yes. It's ASF-wide. |
|
I have received confirmation that the ICLA has been filed in the ASF records, I think you might need the id |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed compiling a template containing
<#sep>using a configuration specifying the square bracket tag syntax fails with afreemarker.core.ParseException: Syntax error in template "X" in line Y, column Z: #sep must be inside a #list (or #foreach) block.I think<#sep>should be ignored instead as it is not using the square bracket syntax.This PR adds a unit test covering that case, a change in
FTL.jjthat solves the issue, and fixes a typo../gradlew checkruns successfully for me with these changes, but I do not know the Freemarker codebase well enough to be confident that it does not introduce other issues.I'd be happy to improve this PR if there is any feedback.