Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-1057] Surefire doesn't detect TestNG test method which fails b... #69

Closed
wants to merge 3 commits into from

Conversation

mbocek
Copy link

@mbocek mbocek commented Nov 16, 2014

Surefire doesn't detect TestNG test method which fails because of exception in @dataProvider method.
Also TestNG SkipException wasn't properly populated to the report.

@Tibor17
Copy link
Contributor

Tibor17 commented Nov 16, 2014

@mbocek
I would assign the bugfix to surefire 2.19 if you create an integration tests.
Pls make sure that your IT fails without the fix.
To do it write the IT, execute mvn verify, It should take 20min to complete the build including all ITs.
Open GitGui "Amend Last Commit", commit the IT, and override the PR:
git push [email protected]:mbocek/maven-surefire.git +master
I hope this would work for you. I should push your PR to ASF, so overriding your PR is finally easier for me than your squashing commits.

@mbocek mbocek closed this Nov 17, 2014
@mbocek
Copy link
Author

mbocek commented Nov 17, 2014

I have opened new PR #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants