[MNG-8573] OS Service

[cstamas]

And move the OS static helper to util, is not
profile specific.

---

https://issues.apache.org/jira/browse/MNG-8573

[pzygielo]

I hope this javadoc could be reworded.

[cstamas]

sure, am just testing our reviewers "eagle eye"

[elharo]

I don't see why we need a wrapper around the utility class. This feels like added complexity for no special purpose.

[cstamas]

The goal is simple:

• the API is meant for plugins and extensions, while Maven "inner stuff" do have the static helper class
• having Service (instead of static class/methods) we are in greater control and are future proof
• for example (unsure how feasible this would be), we could test plugins on "spoofed OS"es?

[gnodet]

I've enhanced the javadoc, but I wonder if it would make more sense to use proper enums, as we don't even define the values.

[cstamas]

Yes, I intentionally left them out, as IMO this service would be most used for things like:

• print out some OS related stuff (like mvn -V does)
• the "is windows" stuff is hot and will be most used, as I envision, as many if not all plugins has IF/ELSE logic to perform hoops and loops

I just wanted to keep this OS stuff small, minimal. And once service, we can later extend it with new methods, as required or we spot some need.

[gnodet]

LGTM