Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9176] Fix pop message header missing fields when enable ACL 2.0 #9179

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

zhiliatom
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9176

Brief Description

开启Authorization后,org.apache.rocketmq.auth.authorization.builder.DefaultAuthorizationContextBuilder#buildContextByAnnotation,会对PopMessageRequestHeader做一次decode并且更新缓存,但此cache不携带bornTime字段,POPMessageProcessor处理请求时从cache中获取错误的Header,导致requestHeader.isTimeoutTooMuch() 校验全部超时,无法消费消息。

How Did You Test This Change?

add bordTime

@lizhimins lizhimins changed the title Fix pop decode [ISSUE #9176] Fix pop message header missing fields when enable ACL 2.0 Feb 13, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.04%. Comparing base (c24f654) to head (2e12375).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9179      +/-   ##
=============================================
- Coverage      48.09%   48.04%   -0.06%     
+ Complexity     12103    12086      -17     
=============================================
  Files           1321     1321              
  Lines          93040    93041       +1     
  Branches       11924    11924              
=============================================
- Hits           44745    44697      -48     
- Misses         42782    42812      +30     
- Partials        5513     5532      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins merged commit 5ca4dfe into apache:develop Feb 21, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] POP Msg failed when enable Authorization of ACL 2.0
4 participants