Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt new Browser data upload protocol #13009

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Adapt new Browser data upload protocol #13009

merged 2 commits into from
Jan 24, 2025

Conversation

mrproliu
Copy link
Contributor

Implementation https://github.com/apache/skywalking/blob/master/docs/en/api/browser-http-api-protocol.md#post-httplocalhost12800browserperfdatawebinteractions protocol in the OAP backend.

image

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@mrproliu mrproliu added protocol agent->collector or UI->collector protocols related. enhancement Enhancement on performance or codes labels Jan 24, 2025
@mrproliu mrproliu added this to the 10.2.0 milestone Jan 24, 2025
@mrproliu mrproliu requested a review from wu-sheng January 24, 2025 02:58
wu-sheng
wu-sheng previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fine0830 could you check the pages? Is that good?

@Fine0830
Copy link
Member

Can you change the INP avg metric to INP percentile? @mrproliu I think some users are having a very fast experience, and some are having a very slow experience. Bimodal distributions like this are very common when measuring user interaction times. Using an average can mislead.

@mrproliu
Copy link
Contributor Author

Can you change the INP avg metric to INP percentile? @mrproliu I think some users are having a very fast experience, and some are having a very slow experience. Bimodal distributions like this are very common when measuring user interaction times. Using an average can mislead.

Done. Here is the update.
image

Fine0830
Fine0830 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@Fine0830 Fine0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 8ebb52d into apache:master Jan 24, 2025
160 checks passed
@wu-sheng
Copy link
Member

@Fine0830 We will fire 10.2 release after Chines new year when BanyanDB 0.8 is ready.
You could consider your client js release date accordingly.

@mrproliu mrproliu deleted the web-interactions branch January 24, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fine0830 Fine0830 Fine0830 approved these changes

@wu-sheng wu-sheng wu-sheng left review comments

Assignees
No one assigned
Labels
enhancement Enhancement on performance or codes protocol agent->collector or UI->collector protocols related.
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mrproliu @Fine0830 @wu-sheng