[SPARK-48413][SQL][FOLLOW-UP] Fix ALTER COLUMN with collation #48582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailom-db
reviewed
Oct 21, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
Outdated
Show resolved
Hide resolved
mihailom-db
reviewed
Oct 22, 2024
Comment on lines
523
to
524
| sql(s"ALTER TABLE $tableName ALTER COLUMN c1 TYPE STRING COLLATE UTF8_LCASE") | ||
| sql(s"INSERT INTO $tableName VALUES ('a')") |
There was a problem hiding this comment.
Suggested change
| sql(s"ALTER TABLE $tableName ALTER COLUMN c1 TYPE STRING COLLATE UTF8_LCASE") | |
| sql(s"INSERT INTO $tableName VALUES ('a')") | |
| sql(s"INSERT INTO $tableName VALUES ('a')") | |
| sql(s"ALTER TABLE $tableName ALTER COLUMN c1 TYPE STRING COLLATE UTF8_LCASE") |
There was a problem hiding this comment.
Let's first insert and then alter, seems a bit nicer for the test.
| @@ -516,6 +516,16 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlanHelper { | |||
| } | |||
| } | |||
|
|
|||
| test("SPARK-48413: Alter column with collation") { | |||
There was a problem hiding this comment.
can we also add tests for complex types (struct, map, array)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixing the analysis check error introduced in PR.
Why are the changes needed?
Change is needed to enable altering column with all datasources and identifier variations.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added tests to
CollationSuite.Was this patch authored or co-authored using generative AI tooling?
No.