Update GraphSONv4 labels, extended type names and edge properties. #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VOTE +1 |
vkagamlyk
reviewed
Sep 27, 2024
| @@ -150,8 +162,10 @@ public void shouldHandlePath() throws Exception { | |||
| extend("alice", new HashSet<>(Collections.singletonList("c"))); | |||
| final String json = mapper.writeValueAsString(p); | |||
|
|
|||
| if (version.startsWith("v1") || version.startsWith("v3") || version.startsWith("v4")) | |||
| if (version.startsWith("v1") || version.startsWith("v3")) | |||
There was a problem hiding this comment.
do we need tests for v1 and v3?
There was a problem hiding this comment.
Probably. The old GraphSONMappers should stay as they can be used with io(). It would be best if users updated their storage format to v4, but all versions should be provided so that the user can read in an older version then write into v4.
|
VOTE +1 |
1 similar comment
|
VOTE +1 |
kenhuuu
force-pushed
the
v4-graphson-updates
branch
from
b479dce to
edb4b8d
Compare
kenhuuu
added a commit
that referenced
this pull request
Nov 2, 2024
kenhuuu
added a commit
that referenced
this pull request
Nov 3, 2024
kenhuuu
added a commit
that referenced
this pull request
Nov 3, 2024
kenhuuu
added a commit
that referenced
this pull request
Nov 3, 2024
kenhuuu
added a commit
that referenced
this pull request
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates bring the implementation closer to the format specified in https://github.com/apache/tinkerpop/blob/master-http/docs/src/dev/io/graphson.asciidoc
VOTE +1