fix: use temp variable (#1)

* fix: replace empty pic link * fix: img url * fix: use temp --------- Co-authored-by: wangbo <[email protected]>
apitable · Feb 9, 2023 · e868f62 · e868f62
1 parent da1649e
commit e868f62
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 61,498 deletions.
diff --git a/dist/packed/widget_bundle.js b/dist/packed/widget_bundle.js
diff --git a/dist/packed/widget_bundle.min.js b/dist/packed/widget_bundle.min.js
diff --git a/src/components/chart/empty_content/empty_content.tsx b/src/components/chart/empty_content/empty_content.tsx
@@ -20,7 +20,7 @@ export function defaultEmptyContent(props: EmptyContentProps) {
     >
       <img
         alt="empty-image"
-        src="../../../img/empty.png"
+        src="https://legacy-s1.apitable.com/space/2022/02/16/7f9dca59465c4ac8be91dbbf1ab4abad"
         style={{
           width: 160,
           height: 120,

diff --git a/src/components/setting/fieldItem/fieldItem.tsx b/src/components/setting/fieldItem/fieldItem.tsx
@@ -22,7 +22,8 @@ export const FieldItem: React.FC<IFieldItem> = (props) => {
   const number_fields = getNumFields(viewId);
 
   const changeHandler = (option) => {
-    dimensionFieldIds.splice(i, 1, option.value);
+    let tempDimensionFieldIds = [...dimensionFieldIds]
+    tempDimensionFieldIds.splice(i, 1, option.value);
     // // TODO: Subsequent sorting function development modify this function
     // switch (mode) {
     //   case "2":
@@ -42,8 +43,7 @@ export const FieldItem: React.FC<IFieldItem> = (props) => {
     //     );
     //     break;
     // }
-
-    setConfig(config);
+    setConfig({ ...config, dimensionFieldIds: tempDimensionFieldIds });
   };
 
   return isSettingOpened ? (
@@ -75,8 +75,9 @@ export const FieldItem: React.FC<IFieldItem> = (props) => {
           size="small"
           className={"dragHandler"}
           onClick={() => {
-            config.dimensionFieldIds.splice(i, 1);
-            setConfig({ ...config, dimensionFieldIds });
+            let tempDimensionFieldIds = [...config.dimensionFieldIds]
+            tempDimensionFieldIds.splice(i, 1);
+            setConfig({ ...config, dimensionFieldIds: tempDimensionFieldIds });
           }}
         />
       </IconWrap>

diff --git a/src/components/setting/setting.tsx b/src/components/setting/setting.tsx
@@ -88,8 +88,9 @@ export const Setting: React.FC<ISettingProps> = (props) => {
       console.error("No empty position");
       return;
     }
-    dimensionFieldIds.push(number_fields[first_one].id);
-    setConfig(config);
+    let tempDimensionFieldIds = [...dimensionFieldIds]
+    tempDimensionFieldIds.push(number_fields[first_one].id);
+    setConfig({ ...config, dimensionFieldIds: tempDimensionFieldIds });
   };
 
   return (

diff --git a/src/img/empty.png b/src/img/empty.png