reuse playwright tests for integration tests of React Router and TanStack #426
Conversation
|
commit: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
#468 Bundle Size — 1.3MiB (+3.95%).c7cddb1(current) vs 5293db1 main#409(baseline) Warning Bundle contains 1 duplicate package – View duplicate packages Warning Bundle introduced one new package: process – View changed packages Bundle metrics
|
| Current #468 |
Baseline #409 |
|
|---|---|---|
 Initial JS |
1.05MiB(+5.44%) |
1016.91KiB |
 Initial CSS |
0B(-100%) |
70B |
 Cache Invalidation |
80.16% |
0.08% |
 Chunks |
34 |
34 |
| Assets |
58(-1.69%) |
59 |
| Modules |
664(+4.4%) |
636 |
| Duplicate Modules |
89(-16.04%) |
106 |
| Duplicate Code |
3.91%(-16.81%) |
4.7% |
| Packages |
25(-3.85%) |
26 |
| Duplicate Packages |
1 |
1 |
Bundle size by type 2 changes 2 regressions
| Current #468 |
Baseline #409 |
|
|---|---|---|
| JS |
1.29MiB (+100%) |
undefined |
| Other |
9.23KiB (+100%) |
undefined |
Bundle analysis report Branch pr/refactor-tests Project dashboard
Generated by RelativeCI Documentation Report issue
phryneas
force-pushed
the
pr/refactor-tests
branch
from
f9c7b7b to
6ac9152
Compare
| BASE_URL: ${{ github.event.deployment_status.environment_url }} | ||
|
|
||
| - name: "Run Playwright tests against Vercel deployment - React Router" | ||
| if: github.event.deployment_status.environment == 'Preview – apoll__client-integration-react-router' |
There was a problem hiding this comment.
| if: github.event.deployment_status.environment == 'Preview – apoll__client-integration-react-router' | |
| if: github.event.deployment_status.environment == 'Preview – apollo__client-integration-react-router' |
| if: | | ||
| github.event_name == 'deployment_status' && github.event.deployment_status.state == 'success' && ( | ||
| github.event.deployment_status.environment == 'Preview – apollo__experimental-nextjs-app-support' || | ||
| github.event.deployment_status.environment == 'Preview – apollo__client-integration-tanstack-start' |
There was a problem hiding this comment.
Does this need to include react router or is it intentionally omitted?
There was a problem hiding this comment.
Very good call! I can't test this until it hits main, so this is a bit hazy to test (I'll probably cherry-pick this file over)
| <> | ||
| <p>{error.message}</p> | ||
| </> |
There was a problem hiding this comment.
| <> | |
| <p>{error.message}</p> | |
| </> | |
| <p>{error.message}</p> |
The smallest of nitpicks since its in a test, but figured I'd comment anyways 🤣
| context: { delay: 1000, ...(errorIn ? { error: errorIn } : {}) }, | ||
| }); | ||
| return { | ||
| queryRef, |
There was a problem hiding this comment.
I'm curious how queryRef plays a role here since its not used in Child or RouteComponent. Would you mind explaining that one? Is just calling preloadQuery enough?
There was a problem hiding this comment.
Just calling preloadQuery won't do anything - the signal that the data should go over the network is the act of including the queryRef in the loader return value.
The queryRef will get hydrated on arrival in the browser and start filling the cache - for that part it doesn't matter if you actually use it.
Compare this to useBackgroundQuery without actually listening on the ref - the network request happens anyways.
No description provided.