update validation snapshots

apollographql · Sep 23, 2024 · 9199749 · 9199749
1 parent c8142f9
commit 9199749
Show file tree

Hide file tree

Showing 52 changed files with 106 additions and 742 deletions.
diff --git a/...nnect/validation/snapshots/validation_tests@absolute_connect_url_with_source.graphql.snap b/...nnect/validation/snapshots/validation_tests@absolute_connect_url_with_source.graphql.snap
@@ -8,13 +8,7 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/absolute_
         code: AbsoluteConnectUrlWithSource,
         message: "`GET` in `@connect(http:)` on `Query.resources` contains the absolute URL \"http://127.0.0.1/resources\" while also specifying a `source`. Either remove the `source` argument or change the URL to a path.",
         locations: [
-            LineColumn {
-                line: 12,
-                column: 15,
-            }..LineColumn {
-                line: 12,
-                column: 48,
-            },
+            12:20..12:48,
         ],
     },
 ]
diff --git a/...rc/sources/connect/validation/snapshots/validation_tests@all_fields_selected.graphql.snap b/...rc/sources/connect/validation/snapshots/validation_tests@all_fields_selected.graphql.snap
@@ -8,65 +8,35 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/all_field
         code: UnresolvedField,
         message: "No connector resolves field `T.unselected`. It must have a `@connect` directive or appear in `@connect(selection:)`.",
         locations: [
-            LineColumn {
-                line: 34,
-                column: 3,
-            }..LineColumn {
-                line: 34,
-                column: 22,
-            },
+            34:3..34:22,
         ],
     },
     Message {
         code: UnresolvedField,
         message: "No connector resolves field `T.secondUnused`. It must have a `@connect` directive or appear in `@connect(selection:)`.",
         locations: [
-            LineColumn {
-                line: 48,
-                column: 3,
-            }..LineColumn {
-                line: 48,
-                column: 23,
-            },
+            48:3..48:23,
         ],
     },
     Message {
         code: UnresolvedField,
         message: "No connector resolves field `C.unselected`. It must have a `@connect` directive or appear in `@connect(selection:)`.",
         locations: [
-            LineColumn {
-                line: 54,
-                column: 3,
-            }..LineColumn {
-                line: 54,
-                column: 21,
-            },
+            54:3..54:21,
         ],
     },
     Message {
         code: UnresolvedField,
         message: "No connector resolves field `D.unselected`. It must have a `@connect` directive or appear in `@connect(selection:)`.",
         locations: [
-            LineColumn {
-                line: 59,
-                column: 3,
-            }..LineColumn {
-                line: 59,
-                column: 21,
-            },
+            59:3..59:21,
         ],
     },
     Message {
         code: UnresolvedField,
         message: "No connector resolves field `Unused.unselected`. It must have a `@connect` directive or appear in `@connect(selection:)`.",
         locations: [
-            LineColumn {
-                line: 63,
-                column: 3,
-            }..LineColumn {
-                line: 63,
-                column: 18,
-            },
+            63:3..63:18,
         ],
     },
 ]
diff --git a/...src/sources/connect/validation/snapshots/validation_tests@circular_reference.graphql.snap b/...src/sources/connect/validation/snapshots/validation_tests@circular_reference.graphql.snap
@@ -8,27 +8,9 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/circular_
         code: CircularReference,
         message: "Circular reference detected in `@connect(selection:)` on `Query.me`: type `User` appears more than once in `Query.me.friends`. For more information, see https://go.apollo.dev/connectors/limitations#circular-references",
         locations: [
-            LineColumn {
-                line: 9,
-                column: 61,
-            }..LineColumn {
-                line: 9,
-                column: 78,
-            },
-            LineColumn {
-                line: 8,
-                column: 5,
-            }..LineColumn {
-                line: 9,
-                column: 79,
-            },
-            LineColumn {
-                line: 14,
-                column: 5,
-            }..LineColumn {
-                line: 14,
-                column: 22,
-            },
+            9:61..9:78,
+            8:5..9:79,
+            14:5..14:22,
         ],
     },
 ]
diff --git a/...c/sources/connect/validation/snapshots/validation_tests@circular_reference_2.graphql.snap b/...c/sources/connect/validation/snapshots/validation_tests@circular_reference_2.graphql.snap
@@ -8,20 +8,8 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/circular_
         code: CircularReference,
         message: "Circular reference detected in `@connect(selection:)` on `Track.modules`: type `Track` appears more than once in `Track.modules.track`. For more information, see https://go.apollo.dev/connectors/limitations#circular-references",
         locations: [
-            LineColumn {
-                line: 18,
-                column: 18,
-            }..LineColumn {
-                line: 18,
-                column: 51,
-            },
-            LineColumn {
-                line: 25,
-                column: 3,
-            }..LineColumn {
-                line: 25,
-                column: 15,
-            },
+            18:18..18:51,
+            25:3..25:15,
         ],
     },
 ]
diff --git a/...c/sources/connect/validation/snapshots/validation_tests@circular_reference_3.graphql.snap b/...c/sources/connect/validation/snapshots/validation_tests@circular_reference_3.graphql.snap
@@ -8,13 +8,7 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/circular_
         code: CircularReference,
         message: "Direct circular reference detected in `User.friends: [User!]!`. For more information, see https://go.apollo.dev/connectors/limitations#circular-references",
         locations: [
-            LineColumn {
-                line: 16,
-                column: 3,
-            }..LineColumn {
-                line: 20,
-                column: 6,
-            },
+            16:3..20:6,
         ],
     },
 ]
diff --git a/...s/connect/validation/snapshots/validation_tests@connect_source_name_mismatch.graphql.snap b/...s/connect/validation/snapshots/validation_tests@connect_source_name_mismatch.graphql.snap
@@ -8,13 +8,7 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/connect_s
         code: SourceNameMismatch,
         message: "`@connect(source: \"v1\")` on `Query.resources` does not match any defined sources. Did you mean `@source(name: \"v2\")`?",
         locations: [
-            LineColumn {
-                line: 10,
-                column: 14,
-            }..LineColumn {
-                line: 10,
-                column: 26,
-            },
+            10:14..10:26,
         ],
     },
 ]
diff --git a/...urces/connect/validation/snapshots/validation_tests@connect_source_undefined.graphql.snap b/...urces/connect/validation/snapshots/validation_tests@connect_source_undefined.graphql.snap
@@ -8,13 +8,7 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/connect_s
         code: NoSourcesDefined,
         message: "`@connect(source: \"v1\")` on `Query.resources` specifies a source, but none are defined. Try adding `@source(name: \"v1\")` to the schema.",
         locations: [
-            LineColumn {
-                line: 9,
-                column: 14,
-            }..LineColumn {
-                line: 9,
-                column: 26,
-            },
+            9:14..9:26,
         ],
     },
 ]
diff --git a/...rces/connect/validation/snapshots/validation_tests@disallowed_abstract_types.graphql.snap b/...rces/connect/validation/snapshots/validation_tests@disallowed_abstract_types.graphql.snap
@@ -8,26 +8,14 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/disallowe
         code: UnsupportedAbstractType,
         message: "Abstract schema types, such as `interface`, are not supported when using connectors. You can check out our documentation at https://go.apollo.dev/connectors/best-practices#abstract-schema-types-are-unsupported.",
         locations: [
-            LineColumn {
-                line: 21,
-                column: 1,
-            }..LineColumn {
-                line: 21,
-                column: 18,
-            },
+            21:1..21:18,
         ],
     },
     Message {
         code: UnsupportedAbstractType,
         message: "Abstract schema types, such as `union`, are not supported when using connectors. You can check out our documentation at https://go.apollo.dev/connectors/best-practices#abstract-schema-types-are-unsupported.",
         locations: [
-            LineColumn {
-                line: 25,
-                column: 1,
-            }..LineColumn {
-                line: 25,
-                column: 12,
-            },
+            25:1..25:12,
         ],
     },
 ]
diff --git a/.../connect/validation/snapshots/validation_tests@disallowed_federation_imports.graphql.snap b/.../connect/validation/snapshots/validation_tests@disallowed_federation_imports.graphql.snap
@@ -8,39 +8,21 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/disallowe
         code: UnsupportedFederationDirective,
         message: "The directive `@context` is not supported when using connectors.",
         locations: [
-            LineColumn {
-                line: 6,
-                column: 7,
-            }..LineColumn {
-                line: 6,
-                column: 17,
-            },
+            6:7..6:17,
         ],
     },
     Message {
         code: UnsupportedFederationDirective,
         message: "The directive `@fromContext` is not supported when using connectors.",
         locations: [
-            LineColumn {
-                line: 7,
-                column: 7,
-            }..LineColumn {
-                line: 7,
-                column: 21,
-            },
+            7:7..7:21,
         ],
     },
     Message {
         code: UnsupportedFederationDirective,
         message: "The directive `@interfaceObject` is not supported when using connectors.",
         locations: [
-            LineColumn {
-                line: 8,
-                column: 7,
-            }..LineColumn {
-                line: 8,
-                column: 25,
-            },
+            8:7..8:25,
         ],
     },
 ]
diff --git a/.../sources/connect/validation/snapshots/validation_tests@duplicate_source_name.graphql.snap b/.../sources/connect/validation/snapshots/validation_tests@duplicate_source_name.graphql.snap
@@ -8,20 +8,8 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/duplicate
         code: DuplicateSourceName,
         message: "Every `@source(name:)` must be unique. Found duplicate name \"v1\".",
         locations: [
-            LineColumn {
-                line: 6,
-                column: 3,
-            }..LineColumn {
-                line: 6,
-                column: 61,
-            },
-            LineColumn {
-                line: 7,
-                column: 3,
-            }..LineColumn {
-                line: 7,
-                column: 61,
-            },
+            6:3..6:61,
+            7:3..7:61,
         ],
     },
 ]
diff --git a/...on/src/sources/connect/validation/snapshots/validation_tests@empty_selection.graphql.snap b/...on/src/sources/connect/validation/snapshots/validation_tests@empty_selection.graphql.snap
@@ -8,26 +8,14 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/empty_sel
         code: InvalidJsonSelection,
         message: "`@connect(selection:)` on `Query.resources` is empty",
         locations: [
-            LineColumn {
-                line: 13,
-                column: 18,
-            }..LineColumn {
-                line: 13,
-                column: 29,
-            },
+            13:18..13:29,
         ],
     },
     Message {
         code: InvalidJsonSelection,
         message: "`@connect(http: {body:})` on `Query.resources` is empty",
         locations: [
-            LineColumn {
-                line: 12,
-                column: 35,
-            }..LineColumn {
-                line: 12,
-                column: 45,
-            },
+            12:41..12:45,
         ],
     },
 ]
diff --git a/.../src/sources/connect/validation/snapshots/validation_tests@empty_source_name.graphql.snap b/.../src/sources/connect/validation/snapshots/validation_tests@empty_source_name.graphql.snap
@@ -8,13 +8,7 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/empty_sou
         code: EmptySourceName,
         message: "The value for `@source(name:)` can't be empty.",
         locations: [
-            LineColumn {
-                line: 6,
-                column: 17,
-            }..LineColumn {
-                line: 6,
-                column: 19,
-            },
+            6:17..6:19,
         ],
     },
 ]
diff --git a/.../sources/connect/validation/snapshots/validation_tests@fields_with_arguments.graphql.snap b/.../sources/connect/validation/snapshots/validation_tests@fields_with_arguments.graphql.snap
@@ -8,20 +8,8 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/fields_wi
         code: FieldWithArguments,
         message: "`@connect(selection:)` on `Query.ts` selects field `T.field`, which has arguments. Only fields with a connector can have arguments.",
         locations: [
-            LineColumn {
-                line: 9,
-                column: 18,
-            }..LineColumn {
-                line: 12,
-                column: 10,
-            },
-            LineColumn {
-                line: 18,
-                column: 3,
-            }..LineColumn {
-                line: 18,
-                column: 29,
-            },
+            9:18..12:10,
+            18:3..18:29,
         ],
     },
 ]
diff --git a/...rces/connect/validation/snapshots/validation_tests@group_selection_on_scalar.graphql.snap b/...rces/connect/validation/snapshots/validation_tests@group_selection_on_scalar.graphql.snap
@@ -8,20 +8,8 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/group_sel
         code: GroupSelectionIsNotObject,
         message: "`@connect(selection:)` on `Query.me` selects a group `id{}`, but `User.id` is of type `ID` which is not an object.",
         locations: [
-            LineColumn {
-                line: 8,
-                column: 77,
-            }..LineColumn {
-                line: 8,
-                column: 88,
-            },
-            LineColumn {
-                line: 12,
-                column: 5,
-            }..LineColumn {
-                line: 12,
-                column: 12,
-            },
+            8:77..8:88,
+            12:5..12:12,
         ],
     },
 ]
diff --git a/...sources/connect/validation/snapshots/[email protected] b/...sources/connect/validation/snapshots/[email protected]
@@ -8,13 +8,7 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/invalid-p
         code: InvalidUrl,
         message: "`GET` in `@connect(http:)` on `Query.resources` must be a valid URL template. Variable type must be one of $args, $this, $config, got $blah",
         locations: [
-            LineColumn {
-                line: 12,
-                column: 23,
-            }..LineColumn {
-                line: 12,
-                column: 28,
-            },
+            12:23..12:28,
         ],
     },
 ]
diff --git a/...s/connect/validation/snapshots/validation_tests@invalid_chars_in_source_name.graphql.snap b/...s/connect/validation/snapshots/validation_tests@invalid_chars_in_source_name.graphql.snap
@@ -8,13 +8,7 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/invalid_c
         code: InvalidSourceName,
         message: "There are invalid characters in `@source(name: \"u$ers\")`. Only alphanumeric and underscores are allowed.",
         locations: [
-            LineColumn {
-                line: 6,
-                column: 17,
-            }..LineColumn {
-                line: 6,
-                column: 24,
-            },
+            6:17..6:24,
         ],
     },
 ]