Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/dev' into feature/configvalidate…
Browse files Browse the repository at this point in the history
…subcommand
  • Loading branch information
andrewmcgivery committed Jan 8, 2025
2 parents df1b898 + 4dd7df8 commit ff564b3
Show file tree
Hide file tree
Showing 865 changed files with 40,731 additions and 22,710 deletions.
5 changes: 5 additions & 0 deletions .changesets/exp_bnjjj_fix_retry_metric.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Remove experimental_retry ([PR #6338](https://github.com/apollographql/router/pull/6338))

Remove `experimental_retry`. Looking at our analytics it looks like it's not used and it's not working properly. As it was an experimental feature in order to check if we needed this feature or not we decided to remove it.

By [@bnjjj](https://github.com/bnjjj) in https://github.com/apollographql/router/pull/6338
10 changes: 10 additions & 0 deletions .changesets/fix_fix_invalid_error_path.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
### Truncating Invalid Error Paths ([PR #6359](https://github.com/apollographql/router/pull/6359))

This fix addresses an issue where the router was silently dropping subgraph errors that included invalid paths.

According to the [GraphQL Specification](https://spec.graphql.org/draft/#sel-GAPHRPHCAACCpC8-T) an error path must point to a **response field**:
> If an error can be associated to a particular field in the GraphQL result, it must contain an entry with the key path that details the path of the response field which experienced the error.
If a subgraph error includes a path that can't be matched to a response field, the router now truncates the path to the nearest valid field path.

By [@IvanGoncharov](https://github.com/IvanGoncharov) in https://github.com/apollographql/router/pull/6359
5 changes: 5 additions & 0 deletions .changesets/fix_tninesling_subscription_operation_init.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Eagerly init subgraph operation for subscription primary nodes ([PR #6509](https://github.com/apollographql/router/pull/6509))

When subgraph operations are deserialized, typically from a query plan cache, they are not automatically parsed into a full document. Instead, each node needs to initialize its operation(s) prior to execution. With this change, the primary node inside SubscriptionNode is initialized in the same way as other nodes in the plan.

By [@tninesling](https://github.com/tninesling) in https://github.com/apollographql/router/pull/6509
5 changes: 0 additions & 5 deletions .changesets/maint_feature_rhaitelemetry.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changesets/maint_renee_migrate_metrics_histograms.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Migrate histogram metrics to `{f,u}64_histogram!` ([PR #6356](https://github.com/apollographql/router/pull/6356))

Updates histogram metrics using the legacy `tracing::info!(histogram.*)` syntax to the new metrics macros.

By [@goto-bus-stop](https://github.com/goto-bus-stop) in https://github.com/apollographql/router/pull/6356
5 changes: 5 additions & 0 deletions .changesets/maint_renee_migrate_metrics_values.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Migrate gauge metrics to OTel instruments ([PR #6476](https://github.com/apollographql/router/pull/6476))

Updates gauge metrics using the legacy `tracing::info!(value.*)` syntax to OTel instruments.

By [@goto-bus-stop](https://github.com/goto-bus-stop) in https://github.com/apollographql/router/pull/6476
11 changes: 11 additions & 0 deletions .changesets/maint_simon_unbridge.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
### Remove the legacy query planner ([PR #6418](https://github.com/apollographql/router/pull/6418))

The legacy query planner has been removed in this release. In the previous release, Router 1.58, it was already no longer used by default but it was still available through the `experimental_query_planner_mode` configuration key. That key is now removed.

Also removed are configuration keys which were only relevant to the legacy planner:

* `supergraph.query_planning.experimental_parallelism`: the new planner can always use available parallelism.
* `supergraph.experimental_reuse_query_fragments`: this experimental algorithm that attempted to
reuse fragments from the original operation while forming subgraph requests is no longer present. Instead, by default new fragment definitions are generated based on the shape of the subgraph operation.

By [@SimonSapin](https://github.com/SimonSapin) in https://github.com/apollographql/router/pull/6418
Loading

0 comments on commit ff564b3

Please sign in to comment.