Merge dev into next #6204
Merged
Merge dev into next #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Renée <[email protected]>
Co-authored-by: Jesse Rosenberger <[email protected]>
…etween Rust QP and JS QP (#6090)
Co-authored-by: Edward Huang <[email protected]>
Co-authored-by: Renée <[email protected]>
…on the same selection (#6120)
The following is now done in `QueryAnalysisLayer` instead of in the `BridgeQueryPlanner` service: * Finding the relevant operation in a GraphQL document based on `operationName`. Now `ParsedDocument` in context contains a reference to the parsed `apollo_compiler::executable::Operation`. * Scan that operation’s root fields to find which are present: root `__typename`, schema intropsection, and "normal" non-meta fields. This is a preliminary step to moving introspection out of `BridgeQueryPlanner`. As a side-effect observable to clients, the exact response for some error cases like an empty document changes slightly as the error no longer comes from JavaScript code. Also drive-by refactor: change `spec::Query` to contain a single `Operation` instead of a `Vec<Operation>`. This removes conditionals and the need to pass `operationName` around in a lot of places, notably in execution code.
Add an Environment variable to the container that's deployed so that we can easily scan if customers are deploying using the official Helm Chart or some other way.
…e same selection (#6137)
…e __typename selections (#6141) - updated sibling typename optimization to only fold a plain __typename without alias/directives. - also, fixed __typename ordering in fetch operations to put the plain __typename ahead of others.
Signed-off-by: Benjamin <[email protected]> Co-authored-by: Andrew McGivery <[email protected]>
Schema introspection now runs natively without involving JavaScript code. We have high confidence that the two implementations return matching responses based on differential testing fuzzing arbitrary queries against a large schema, and testing a corpus of customer schemas against a comprehensive query. In Router YAML configuration: * The `experimental_introspection_mode` key is removed, `new` is now the only behavior * The `supergraph.query_planning.legacy_introspection_caching` key is removed, the behavior is now similar to what was `false`: introspection responses are not part of the query plan cache but instead in a separate, small, in-memory only cache. Migrations ensure that existing configuration files will keep working.
Co-authored-by: Simon Sapin <[email protected]> Co-authored-by: Jesse Rosenberger <[email protected]>
Updates to latest router-bridge and federation version. This federation version: - Fixes a query planning bug where operation variables for a subgraph query wouldn't match what's used in that query. - Fixes a query planning bug where directives applied to `__typename` may be omitted in the subgraph query. - Fixes a query planning inefficiency where some redundant subgraph queries were not removed. - Fixes a query planning inefficiency where some redundant inline fragments in `@key`/`@requires` selection sets were not optimized away. - Fixes a query planning inefficiency where unnecessary subgraph jumps were being added when using `@context`/`@fromContext`.
Co-authored-by: Lucas Leadbetter <[email protected]>
…raph` and open/closed branches (#6190)
# Conflicts: # CHANGELOG.md # Cargo.lock # apollo-federation/Cargo.toml # apollo-router-benchmarks/Cargo.toml # apollo-router-scaffold/Cargo.toml # apollo-router-scaffold/templates/base/Cargo.template.toml # apollo-router-scaffold/templates/base/xtask/Cargo.template.toml # apollo-router/Cargo.toml # apollo-router/src/services/mod.rs # dockerfiles/tracing/docker-compose.datadog.yml # dockerfiles/tracing/docker-compose.jaeger.yml # dockerfiles/tracing/docker-compose.zipkin.yml # helm/chart/router/Chart.yaml # helm/chart/router/README.md # licenses.html # scripts/install.sh
dylan-apollo
requested review from
a team,
dariuszkuc,
sachindshinde,
goto-bus-stop,
SimonSapin,
lrlna,
TylerBloom and
duckki
as code owners
✅ Docs Preview ReadyNo new or changed pages found. |
|
CI performance tests
|
shorgi
reviewed
Oct 29, 2024
lennyburdette
approved these changes
Oct 31, 2024
pubmodmatt
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix
test-updatedwhich is currently failing onnext. Merge conflicts:experimental_introspection_mode(no longer an option on dev)Closes #6149